Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the FactoryGirl -> FactoryBot rename #168

Open
hrs opened this issue Nov 8, 2017 · 1 comment
Open

Handle the FactoryGirl -> FactoryBot rename #168

hrs opened this issue Nov 8, 2017 · 1 comment

Comments

@hrs
Copy link

hrs commented Nov 8, 2017

The maintainers of FactoryGirl have decided to rename the project to FactoryBot. There's some logic in rspec-mode that uses the string "FactoryGirl", which may be an issue as folks switch over.

(Thanks so much for the great mode, by the way!)

@dgutov
Copy link
Collaborator

dgutov commented Nov 9, 2017

That's a bit non-trivial.

Should we rename the snippets as well? People who use them might have trouble adapting.

And we might have to parse the Gemfile, to see which factory gem is being used. Maybe we should just wait 6-12 months and rename it all then, leaving no compatibility with FactoryGirl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants