Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel promises on category search #57

Open
1 task
peterhil opened this issue Jun 9, 2021 · 1 comment
Open
1 task

Cancel promises on category search #57

peterhil opened this issue Jun 9, 2021 · 1 comment
Assignees
Labels
prio: gambling High effort, possibly high impact technical
Milestone

Comments

@peterhil
Copy link
Owner

peterhil commented Jun 9, 2021

Cancel promises with something like AbortController for fetch.

Bluebird offers cancellable promises and there are other options.

For custom implementation the structure of Promise cancellation could be something like delayedExecution even though this handles callback execution.

  • Cancel Promises for WebExtension API requests when user changes the search or clears the search
@peterhil peterhil self-assigned this Jun 9, 2021
@peterhil peterhil added this to the 0.5.0 milestone Jun 9, 2021
@peterhil peterhil closed this as completed Jun 9, 2021
@peterhil peterhil reopened this Jun 9, 2021
@peterhil peterhil added the prio: gambling High effort, possibly high impact label Jun 11, 2021
@peterhil
Copy link
Owner Author

peterhil commented Jul 12, 2021

Cancelable promise delay can be used instead of debounce and/or throttle to cancel when input changes:
https://twitter.com/oliverjumpertz/status/1414510738119528449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: gambling High effort, possibly high impact technical
Projects
Status: To do
Development

No branches or pull requests

1 participant