From b82335c830e8120e7118c36239a5858fdc43f11c Mon Sep 17 00:00:00 2001 From: Pranav <85227306+Pranavchiku@users.noreply.github.com> Date: Tue, 12 Mar 2024 19:12:34 +0530 Subject: [PATCH] chore: apply suggestions from code review Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com> --- lib/node_modules/@stdlib/blas/ext/base/drev/README.md | 4 ++-- .../@stdlib/blas/ext/base/drev/benchmark/benchmark.js | 2 +- .../@stdlib/blas/ext/base/drev/benchmark/benchmark.native.js | 2 +- .../@stdlib/blas/ext/base/drev/benchmark/benchmark.ndarray.js | 2 +- .../blas/ext/base/drev/benchmark/benchmark.ndarray.native.js | 2 +- lib/node_modules/@stdlib/blas/ext/base/drev/examples/index.js | 4 ++-- .../@stdlib/blas/ext/base/drev/lib/ndarray.native.js | 3 +++ 7 files changed, 11 insertions(+), 8 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/drev/README.md b/lib/node_modules/@stdlib/blas/ext/base/drev/README.md index 886c15a9869..39fd1afcaea 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/drev/README.md +++ b/lib/node_modules/@stdlib/blas/ext/base/drev/README.md @@ -133,8 +133,8 @@ var drev = require( '@stdlib/blas/ext/base/drev' ); var x = filledarrayBy( 10, 'float64', discreteUniform( -100, 100 ) ); console.log( x ); -var y = drev( x.length, x, 1 ); -console.log( y ); +drev( x.length, x, 1 ); +console.log( x ); ``` diff --git a/lib/node_modules/@stdlib/blas/ext/base/drev/benchmark/benchmark.js b/lib/node_modules/@stdlib/blas/ext/base/drev/benchmark/benchmark.js index 0c4825eade6..208e82c3fcd 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/drev/benchmark/benchmark.js +++ b/lib/node_modules/@stdlib/blas/ext/base/drev/benchmark/benchmark.js @@ -31,7 +31,7 @@ var drev = require( './../lib/drev.js' ); // VARIABLES // -var rand = uniform( -100.0, 100.0 ); +var rand = uniform( -10.0, 10.0 ); // FUNCTIONS // diff --git a/lib/node_modules/@stdlib/blas/ext/base/drev/benchmark/benchmark.native.js b/lib/node_modules/@stdlib/blas/ext/base/drev/benchmark/benchmark.native.js index f09ed6d97aa..645e5a8efc0 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/drev/benchmark/benchmark.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/drev/benchmark/benchmark.native.js @@ -36,7 +36,7 @@ var drev = tryRequire( resolve( __dirname, './../lib/drev.native.js' ) ); var opts = { 'skip': ( drev instanceof Error ) }; -var rand = uniform( -100.0, 100.0 ); +var rand = uniform( -10.0, 10.0 ); // FUNCTIONS // diff --git a/lib/node_modules/@stdlib/blas/ext/base/drev/benchmark/benchmark.ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/drev/benchmark/benchmark.ndarray.js index 43570ef265f..12e2b5d4ee8 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/drev/benchmark/benchmark.ndarray.js +++ b/lib/node_modules/@stdlib/blas/ext/base/drev/benchmark/benchmark.ndarray.js @@ -31,7 +31,7 @@ var drev = require( './../lib/ndarray.js' ); // VARIABLES // -var rand = uniform( -100.0, 100.0 ); +var rand = uniform( -10.0, 10.0 ); // FUNCTIONS // diff --git a/lib/node_modules/@stdlib/blas/ext/base/drev/benchmark/benchmark.ndarray.native.js b/lib/node_modules/@stdlib/blas/ext/base/drev/benchmark/benchmark.ndarray.native.js index 2d63175c133..20fa4384274 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/drev/benchmark/benchmark.ndarray.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/drev/benchmark/benchmark.ndarray.native.js @@ -36,7 +36,7 @@ var drev = tryRequire( resolve( __dirname, './../lib/ndarray.native.js' ) ); var opts = { 'skip': ( drev instanceof Error ) }; -var rand = uniform( -100.0, 100.0 ); +var rand = uniform( -10.0, 10.0 ); // FUNCTIONS // diff --git a/lib/node_modules/@stdlib/blas/ext/base/drev/examples/index.js b/lib/node_modules/@stdlib/blas/ext/base/drev/examples/index.js index d89b15a7703..2aa93dcd539 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/drev/examples/index.js +++ b/lib/node_modules/@stdlib/blas/ext/base/drev/examples/index.js @@ -25,5 +25,5 @@ var drev = require( './../lib' ); var x = filledarrayBy( 10, 'float64', discreteUniform( -100, 100 ) ); console.log( x ); -var y = drev( x.length, x, 1 ); -console.log( y ); +drev( x.length, x, 1 ); +console.log( x ); diff --git a/lib/node_modules/@stdlib/blas/ext/base/drev/lib/ndarray.native.js b/lib/node_modules/@stdlib/blas/ext/base/drev/lib/ndarray.native.js index a7d942c7a3b..0f4ea4b8126 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/drev/lib/ndarray.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/drev/lib/ndarray.native.js @@ -46,8 +46,11 @@ var addon = require( './drev.native.js' ); */ function drev( N, x, stride, offset ) { var view; + offset = minViewBufferIndex( N, stride, offset ); + view = offsetView( x, offset ); + addon( N, view, stride ); return x; }