Ttyler 2022 08 shellcheck #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions and bug fixes.
…vior for {push,monitor}_metrics.sh.
…d usage bug, improved error message.
…) calls, fixed bug.
rcowham
reviewed
Aug 31, 2022
scripts/monitor_metrics.sh
Outdated
| @@ -215,8 +221,7 @@ monitor_license () { | |||
| no_license=$(grep -c "Server license: none" "$tmp_info_data") | |||
| # Update every 60 mins | |||
| [[ ! -f "$tmp_license_data" || $(find "$tmp_license_data" -mmin +60) ]] || return | |||
| $p4 license -u 2>&1 > "$tmp_license_data" | |||
| [[ $? -ne 0 ]] && return | |||
| $p4 license -u "$tmp_license_data" 2>&1 || return | |||
There was a problem hiding this comment.
Needs to save output to file!
There was a problem hiding this comment.
Changed pushed to address this - looks like a redirect operator was lost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShellCheck compliance issues fixed.
Some usage bugs fixed.
Preliminary efforts to standardize usage across shell scripts.
chmod +x as needed.