PMM-13111 disable new postgresql collectors. #3111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit f7326cd)
BupycHuk
requested review from
idoqo and
JiriCtvrtka
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3111 +/- ##
==========================================
+ Coverage 43.34% 43.36% +0.01%
==========================================
Files 399 399
Lines 41654 41657 +3
==========================================
+ Hits 18056 18063 +7
+ Misses 21582 21580 -2
+ Partials 2016 2014 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JiriCtvrtka
approved these changes
Aug 1, 2024
|
@idoqo PTAL ^ |
idoqo
approved these changes
Aug 6, 2024
| // DisableDefaultEnabledCollectors returns CLI arguments to disable default enabled collectors based on input. | ||
| // DefaultCollectors and disabledCollectors should be collector names without prefix. | ||
| // Result will be returned with prefix. | ||
| func DisableDefaultEnabledCollectors(prefix string, defaultCollectors []string, disabledCollectors []string) []string { |
There was a problem hiding this comment.
Considering we always use --no-collector as prefix for disabling collectors, should we just make it a constant and drop the prefix parameter?
Suggested change
| func DisableDefaultEnabledCollectors(prefix string, defaultCollectors []string, disabledCollectors []string) []string { | |
| func DisableDefaultEnabledCollectors(defaultCollectors []string, disabledCollectors []string) []string { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-13111
Link to the Feature Build: SUBMODULES-3677
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: