PMM-12894 Add max conneсtions config support for PG exporter #2837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2837 +/- ##
==========================================
+ Coverage 42.22% 42.26% +0.03%
==========================================
Files 396 396
Lines 50120 50120
==========================================
+ Hits 21164 21184 +20
+ Misses 26953 26933 -20
Partials 2003 2003
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Closed
2 tasks
artemgavrilov
changed the title
artemgavrilov
changed the title
artemgavrilov
requested review from
idoqo,
JiriCtvrtka and
ademidoff
and removed request for
a team
artemgavrilov
commented
Feb 22, 2024
idoqo
approved these changes
Feb 26, 2024
BupycHuk
changed the title
BupycHuk
reviewed
Feb 28, 2024
BupycHuk
reviewed
Feb 28, 2024
BupycHuk
reviewed
Feb 28, 2024
| @@ -34,6 +35,7 @@ var ( | |||
| postgresExporterAutodiscoveryVersion = version.MustParse("2.15.99") | |||
| postgresExporterWebConfigVersion = version.MustParse("2.30.99") | |||
| postgresSSLSniVersion = version.MustParse("2.40.99") | |||
| postgresMaxExporterConnsVersion = version.MustParse("2.41.99") | |||
There was a problem hiding this comment.
it will be in 2.41.2 or 2.41.3, so I think better to use version 2.41.2-0
There was a problem hiding this comment.
Done
TODO: double check before merge
JiriCtvrtka
approved these changes
Mar 5, 2024
artemgavrilov
deleted the
PMM-12894-rolling-collection-strategy-for-PG-exporter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-12894
Link to the Feature Build: SUBMODULES-3559
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: