Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPG-543: fix panic #708

Merged
merged 5 commits into from
May 9, 2024
Merged

K8SPG-543: fix panic #708

merged 5 commits into from
May 9, 2024

Conversation

pooknull
Copy link
Contributor

@pooknull pooknull commented Apr 11, 2024

K8SPG-543 Powered by Pull Request Badge

https://perconadev.atlassian.net/browse/K8SPG-543

DESCRIPTION

Problem:
Applying a cr.yaml with empty .spec.proxy field caused operator to panic.

Solution:
Set correct defaults.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are the manifests (crd/bundle) regenerated if needed?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PG version?
  • Does the change support oldest and newest supported Kubernetes version?

@JNKPercona
Copy link
Collaborator

Test name Status
custom-extensions passed
demand-backup passed
init-deploy passed
monitoring passed
operator-self-healing passed
scaling passed
scheduled-backup passed
self-healing passed
start-from-backup passed
telemetry-transfer passed
upgrade-minor passed
users passed
We run 12 out of 12

commit: 58719fd
image: perconalab/percona-postgresql-operator:PR-708-58719fddd

@pooknull pooknull marked this pull request as ready for review May 8, 2024 22:06
@hors hors merged commit 52657cb into main May 9, 2024
7 checks passed
@hors hors deleted the dev/K8SPG-543 branch May 9, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants