Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tower-abci: write integration tests for major cometbft releases #32

Open
erwanor opened this issue Jul 30, 2023 · 0 comments
Open

tower-abci: write integration tests for major cometbft releases #32

erwanor opened this issue Jul 30, 2023 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@erwanor
Copy link
Member

erwanor commented Jul 30, 2023

The current process to test that support for major releases works is through manual testing: spin-up the correct version of cometbft and try to make it work with the key-value store example. Though we should keep some amount of manual testing as part of our quality assurance process, this much could be automated into the CI to make our development flow more robust to accidental regressions.

This ticket has growing priority, as we already support two major versions of CometBFT (with breaking changes to their socket wire protocol), and with #30, we will support one more.

@erwanor erwanor added enhancement New feature or request help wanted Extra attention is needed labels Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
No open projects
Status: Next
Development

No branches or pull requests

1 participant