Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web socket disconnects results in hang #13

Open
conorsch opened this issue Jun 29, 2023 · 1 comment
Open

Web socket disconnects results in hang #13

conorsch opened this issue Jun 29, 2023 · 1 comment

Comments

@conorsch
Copy link
Contributor

We noticed a suppressed rate of tx on the network. Checking osiris, it had failed abotu 15m prior:

Jun 29 00:02:01.902 ERROR osiris::binance_fetcher: error in web socket event loop err=Error(Msg("Disconnected Some(CloseFrame { code: Away, reason: \"\" })"), State { next_error: None, backtrace: InternalBacktrace })

But the process didn't exit. Had it exited entirely, the service would have been automatically restarted. Let's percolate that error up.
conorsch added a commit that referenced this issue Jun 29, 2023
@conorsch
fix: exit on websocket error
c69570b 
If the websocket connection to the Binance API fails, the service should
fail, which will trigger a service restart. Otherwise, the bot gets
stuck. Refs #13.
@conorsch conorsch mentioned this issue Jun 29, 2023
Merged
@conorsch
Copy link
Contributor Author

Saw this again on Testnet 56. Taking another look at propagating errors.

@conorsch conorsch mentioned this issue Jul 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@conorsch