From 7ca1b7ea89ecca9c3f5dff08a69a5e61d0ef3872 Mon Sep 17 00:00:00 2001
From: Conor Schaefer <conor@penumbralabs.xyz>
Date: Mon, 12 Jun 2023 10:14:28 -0700
Subject: [PATCH] ci: add scheduled daily release build

Also updates the GHA helpers to use maintained resources, to minimize
breakage and other surprises. Adds a check to fail on warnings, so
addresses some warnings to satisfy.

Closes #10.
---
 .github/workflows/rust.yml | 95 ++++++++++++++++++--------------------
 src/trader.rs              |  6 +--
 2 files changed, 46 insertions(+), 55 deletions(-)

diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
index 99f6dbf..19f91a1 100644
--- a/.github/workflows/rust.yml
+++ b/.github/workflows/rust.yml
@@ -1,72 +1,65 @@
 name: Rust CI
-on: [push, pull_request]
-
+on:
+  workflow_call:
+  workflow_dispatch:
+  push:
+    branches:
+      - main
+  # Run periodically to check for breakage, since we seldom update the osiris repo.
+  # This allows us to determine approximately when a breaking change was merged into
+  # the penumbra repo, so we can fix it ahead of a testnet release.
+  schedule:
+    - cron: "25 18 * * *"
+  pull_request: {}
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
 jobs:
-  check:
-    name: Check
-    runs-on: ubuntu-latest
+  build:
+    name: Build
+    runs-on: buildjet-16vcpu-ubuntu-2004
     steps:
       - name: Checkout osiris
-        uses: actions/checkout@v2
-        with:
-          path: osiris
+        uses: actions/checkout@v3
 
       - name: Check out penumbra repo
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           repository: penumbra-zone/penumbra
-          path: penumbra
+          path: penumbra-repo
           lfs: true
 
-      - uses: actions-rs/toolchain@v1
-        with:
-          profile: minimal
-          toolchain: stable
-          override: true
+      - name: Move penumbra repo to relative path
+        run: mv penumbra-repo ../penumbra
 
-      - uses: Swatinem/rust-cache@v2
-        with:
-          workspaces: |
-            osiris
-            penumbra
+      - name: Install rust toolchain
+        uses: dtolnay/rust-toolchain@stable
+
+      - name: Configure rust cache
+        uses: Swatinem/rust-cache@v2
 
-      # We cannot use the GH action because it doesn't working directory:
-      # support custom working dirs.
-      # - uses: actions-rs/cargo@v1
-      - name: cargo check
-        run:
-          cargo check
-        working-directory: osiris
+      - name: Run cargo build release
+        run: cargo build --release
+        env:
+          # The `-D warnings` option causes an error on warnings;
+          # we must duplicate the rustflags from penumbra repo's `.cargo/config.toml`.
+          RUSTFLAGS: "-D warnings --cfg tokio_unstable"
 
   fmt:
     name: Rustfmt
-    runs-on: ubuntu-latest
+    runs-on: buildjet-8vcpu-ubuntu-2004
     steps:
       - name: Checkout osiris
-        uses: actions/checkout@v2
-        with:
-          path: osiris
+        uses: actions/checkout@v3
 
-      - name: Check out penumbra repo
-        uses: actions/checkout@v2
-        with:
-          repository: penumbra-zone/penumbra
-          path: penumbra
-          lfs: true
+      # N.B. `cargo fmt` does not require relpath dependencies to be present,
+      # so we don't need to clone the penumbra repo here.
 
-      - uses: actions-rs/toolchain@v1
-        with:
-          profile: minimal
-          toolchain: stable
-          override: true
+      - name: Install rust toolchain
+        uses: dtolnay/rust-toolchain@stable
 
-      - uses: Swatinem/rust-cache@v2
-        with:
-          workspaces: |
-            osiris
-            penumbra
+      - name: Configure rust cache
+        uses: Swatinem/rust-cache@v2
 
-      - name: cargo fmt
-        run:
-          cargo fmt --all -- --check
-        working-directory: osiris
+      - name: Run cargo fmt
+        run: cargo fmt --all -- --check
diff --git a/src/trader.rs b/src/trader.rs
index 4f60db1..d614990 100644
--- a/src/trader.rs
+++ b/src/trader.rs
@@ -247,8 +247,6 @@ where
             }
             self.actions = actions;
         }
-
-        Ok(())
     }
 
     async fn finalize_and_submit(&mut self, plan: &mut Planner<OsRng>) -> anyhow::Result<()> {
@@ -318,7 +316,7 @@ where
         reserves_1: Amount,
         reserves_2: Amount,
         quote: BookTickerEvent,
-        mut plan: &mut Planner<OsRng>,
+        plan: &mut Planner<OsRng>,
     ) -> anyhow::Result<()> {
         // put up half the available reserves
         // TODO: this isn't quite right as it's half the _remaining_ reserves
@@ -378,7 +376,7 @@ where
         );
 
         tracing::trace!(?pos, "opening position");
-        plan = plan.position_open(pos);
+        _ = plan.position_open(pos);
 
         Ok(())
     }