fix: add FeeTier support to galileo tx sending #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quoth @conorsch, in #review-please. there's still a bit of fee plumbing to do, so i've marked this as a draft, but will review once it's ready 🙂 |
cratelyn
approved these changes
Jun 4, 2024
cratelyn
reviewed
Jun 4, 2024
|
Closes #97. Tested by running locally and pasting an address into a private discord channel: received funds. |
cratelyn
approved these changes
Jun 4, 2024
During Testnet 77 we enabled fees [0] and in the process broke some things like Galileo. Adding FeeTier support is rather straightforward, although this changeset requires a patch to the `penumbra-fee` crate in order to compile [1]. [0] penumbra-zone/penumbra#4306 [1] penumbra-zone/penumbra#4539
Closed
Merged
1 task
|
Confirmed this changeset still works after building against penumbra-zone/penumbra#4559 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During Testnet 77 we enabled fees [0] and in the process broke some things like Galileo. Adding FeeTier support is rather straightforward, although this changeset requires a patch to the
penumbra-feecrate in order to compile [1].[0] penumbra-zone/penumbra#4306
[1] penumbra-zone/penumbra#4539