Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(banner):maintenance #288

Merged
merged 4 commits into from
Oct 14, 2023
Merged

feat(banner):maintenance #288

merged 4 commits into from
Oct 14, 2023

Conversation

esinx
Copy link
Member

@esinx esinx commented Oct 14, 2023 •
edited
Loading

Screenshot 2023-10-14 at 5 47 00 PM

joyliu-q
joyliu-q requested changes Oct 14, 2023
View reviewed changes
Copy link
Contributor

@joyliu-q joyliu-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few eslint warning disabling changes. Also, are the doApiRequest correctly configured, because we're hardcoding it for this current maintenance iteration?

frontend/pages/_app.tsx Outdated Show resolved Hide resolved
frontend/pages/_app.tsx Outdated Show resolved Hide resolved
@joyliu-q joyliu-q merged commit 4bddaf4 into master Oct 14, 2023
5 checks passed
@joyliu-q joyliu-q deleted the feat/maintenance-announcement branch October 14, 2023 23:48
kunlizhang pushed a commit that referenced this pull request Nov 5, 2023
@esinx @kunlizhang
feat(banner):maintenance (#288)
50f059a 
* feat(banner):maintenance

* chore: import sort

* lint(resolved)

* lint: specify disable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyliu-q joyliu-q Awaiting requested review from joyliu-q

@danielxue danielxue Awaiting requested review from danielxue

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esinx @joyliu-q