Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matplotlib update to version 2.0 #139

Open
khs26 opened this issue Dec 14, 2015 · 4 comments
Open

Matplotlib update to version 2.0 #139

khs26 opened this issue Dec 14, 2015 · 4 comments

Comments

@khs26
Copy link

khs26 commented Dec 14, 2015

A placeholder issue for matplotlib changes that might break our existing calls. Not sure exactly which changes might need making and I don't currently have time to test it out.

@smcantab
Copy link
Contributor

my opinion is that matplotlib should typically be wrapped in a try
statement, since one typically does not uses matplotlib unless he is
analysing the data. That way it won't break anything if the import is not
resolved at run time, and one can fix it at a later stage during data
analysis if need to

On Mon, Dec 14, 2015 at 5:08 PM, Kyle Sutherland-Cash <
[email protected]> wrote:

A placeholder issue for matplotlib changes that might break our existing
calls. Not sure exactly which changes might need making and I don't
currently have time to test it out.


Reply to this email directly or view it on GitHub
#139.

@khs26
Copy link
Author

khs26 commented Dec 14, 2015

I agree with that. Especially given that it can take some fiddling with the various graphical backends to get it to work reliably. Does the GUI use matplotlib for things that we need to work reliably?

@smcantab
Copy link
Contributor

yes the gui relies heavily on matplotlib, and as far as I can tell it uses
exclusively the QT4Agg backend. As far as I can tell the whole point of the
gui is that one wants to visualise results, so I don't see how you can
bypass matplotlib when using the gui. What I mean is that if there is a
matplotlib import in the NEB source because there is a test snippet at the
end of the script then that should be wrapped in a try statement because it
is not strictly necessary to run a NEB calculation.

On Mon, Dec 14, 2015 at 5:15 PM, Kyle Sutherland-Cash <
[email protected]> wrote:

I agree with that. Especially given that it can take some fiddling with
the various graphical backends to get it to work reliably. Does the GUI use
matplotlib for things that we need to work reliably?


Reply to this email directly or view it on GitHub
#139 (comment).

@smcantab
Copy link
Contributor

re-reading my post I noticed that it might sound a bit passive-aggressive,
it wasn't my intention though! (I was just writing in a bit of a rush) let
me know if I can help on a particular issue related to this

On Mon, Dec 14, 2015 at 5:32 PM, Stefano Martiniani <
[email protected]> wrote:

yes the gui relies heavily on matplotlib, and as far as I can tell it uses
exclusively the QT4Agg backend. As far as I can tell the whole point of the
gui is that one wants to visualise results, so I don't see how you can
bypass matplotlib when using the gui. What I mean is that if there is a
matplotlib import in the NEB source because there is a test snippet at the
end of the script then that should be wrapped in a try statement because it
is not strictly necessary to run a NEB calculation.

On Mon, Dec 14, 2015 at 5:15 PM, Kyle Sutherland-Cash <
[email protected]> wrote:

I agree with that. Especially given that it can take some fiddling with
the various graphical backends to get it to work reliably. Does the GUI use
matplotlib for things that we need to work reliably?


Reply to this email directly or view it on GitHub
#139 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants