chore(release): v2 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes peerjs issue 715
When serializing an object that contains `undefined` as a value, the current packer code incorrectly serializes the value as `null` (0xc0). `null` and `undefined` are not the same thing, and should not be serialized into the same binary representation. Strangely, the unpacker actually does support unpacking `undefined` values using the binary representation 0xc1. There was an old pull request (#4) that seems to address this along with a bunch of other seemingly unrelated changes. The GitHub UI seems to think that the PR was merged manually, but the code that fixes this issue never actually made it into the master branch as far as I can tell. Another option is to omit any keys with `undefined` values. This is what `JSON.stringify` does as `JSON` does not support `undefined` natively. When deserialized, the semantics are mostly correct, as accessing a key that doesn't exist will give you `undefined`. This is slightly more efficient, I suppose and maintain the exact same behavior between binarypack and JSON serialization which is a good thing. However, you can observe the difference with `Object.keys`, `Object.hasOwnProperty`, etc.
The code was assuming that they had UTF-8 length 6 instead of 4, causing a crash on any character above U+FFFF. Also handle unpaired surrogates correctly.
pack_string / unpack_string: handle chars above U+FFFF
npm WARN old lockfile npm WARN old lockfile The package-lock.json file was created with an old version of npm, npm WARN old lockfile so supplemental metadata must be fetched from the registry. npm WARN old lockfile npm WARN old lockfile This is a one-time fix-up, please be patient... npm WARN old lockfile
refactor: typescript strict mode compliant
Githubs runners are slow
* Add renovate.json * ci: configure renovate --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jonas Gloning <[email protected]>
This reverts commit 6cd23f5.
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.