Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Switch to Truststore by default #2200

Merged
merged 1 commit into from
Aug 29, 2023
Merged

fix: Switch to Truststore by default #2200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/2195.feature.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Switch to truststore by default.
2 changes: 1 addition & 1 deletion pdm.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ dependencies = [
"resolvelib>=1.0.1",
"installer<0.8,>=0.7",
"cachecontrol[filecache]>=0.13.0",
"truststore; python_version >= \"3.10\"",
"tomli>=1.1.0; python_version < \"3.11\"",
"importlib-resources>=5; python_version < \"3.9\"",
"importlib-metadata>=3.6; python_version < \"3.10\"",
Expand Down Expand Up @@ -59,9 +60,8 @@ keyring = ["keyring"]
template = [
"pdm[copier,cookiecutter]",
]
truststore = ["truststore; python_version >= \"3.10\""]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the [truststore] extra was used much so this shouldn't be a huge problem (likely many people were getting truststore via pdm[all]) so this should be fine? The pdm[truststore] extra isn't in the docs, but there is a separate section on installing truststore which may not be needed anymore now that it's a default?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting for non-existing extra names will result in a warning. So that is okay.

all = [
"pdm[keyring,template,truststore]",
"pdm[keyring,template]",
]

[project.scripts]
Expand Down