fix: Switch to Truststore by default #2200
Conversation
Fixes #2195 Signed-off-by: Frost Ming <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2200 +/- ##
==========================================
- Coverage 84.27% 84.26% -0.02%
==========================================
Files 100 100
Lines 9787 9787
Branches 2161 2161
==========================================
- Hits 8248 8247 -1
- Misses 1065 1066 +1
Partials 474 474
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -59,9 +60,8 @@ keyring = ["keyring"] | |||
| template = [ | |||
| "pdm[copier,cookiecutter]", | |||
| ] | |||
| truststore = ["truststore; python_version >= \"3.10\""] | |||
There was a problem hiding this comment.
I don't think the [truststore] extra was used much so this shouldn't be a huge problem (likely many people were getting truststore via pdm[all]) so this should be fine? The pdm[truststore] extra isn't in the docs, but there is a separate section on installing truststore which may not be needed anymore now that it's a default?
There was a problem hiding this comment.
Requesting for non-existing extra names will result in a warning. So that is okay.
Fixes #2195
Signed-off-by: Frost Ming [email protected]
Pull Request Checklist
news/describing what is new.Describe what you have changed in this PR.