Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removing dev dependency uninstall the project as well #2162

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

frostming
Copy link
Collaborator

Fixes #2150

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (ad91c72) 84.43% compared to head (0ec304c) 84.42%.
Report is 1 commits behind head on main.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2162      +/-   ##
==========================================
- Coverage   84.43%   84.42%   -0.02%     
==========================================
  Files         100      100              
  Lines        9721     9721              
  Branches     2138     2138              
==========================================
- Hits         8208     8207       -1     
- Misses       1045     1046       +1     
  Partials      468      468              
Flag Coverage Δ
unittests 84.19% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/pdm/cli/actions.py 77.22% <ø> (ø)
src/pdm/cli/commands/add.py 87.32% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming frostming merged commit d20c0ab into main Aug 3, 2023
19 checks passed
@frostming frostming deleted the frostming/issue2150 branch August 3, 2023 00:44
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing dev dependency uninstall the project as well
2 participants