MNT/BLD: unpin pyqt #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These tests are failing due to the bluesky update I think |
|
Should we constrain bluesky or update based on the thoughts in #73 ? |
|
I want to remember hearing something about bluesky 1.11 being pulled/reverted, or at least thought about more. That tips my scales toward pinning, on the off chance some implementation details change. It's also less work for us now, at the cost of being confused about who made the pins later 😆 |
tangkong
reviewed
Jul 24, 2023
| @@ -0,0 +1,22 @@ | |||
| 74 free-pyqt | |||
tangkong
approved these changes
Jul 24, 2023
ZLLentz
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unpin pyqt, leaving it at 5.x.
Motivation and Context
We're looking forward to Python 3.11 everywhere.
hutch-python > nabsdependency means that hutch-python and these libraries currently requirepyqt < 5.15in our environment. Those versions are not available for Python 3.11. PyDM and our other libraries are now (likely/mostly) compatible with PyQt 5.15, so releasing the pin here is our next step toward that transition.How Has This Been Tested?
Untested. Relying on CI, which is likely to fail due to bluesky-related changes.
Where Has This Been Documented?
This PR text.
Pre-merge checklist