Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beamline Macros #34

Open
ZLLentz opened this issue Jan 6, 2021 · 2 comments
Open

Beamline Macros #34

ZLLentz opened this issue Jan 6, 2021 · 2 comments

Comments

@ZLLentz
Copy link
Member

ZLLentz commented Jan 6, 2021

Expected Behavior

There is some proliferation of beamline macros (not plans) in the various hutch-python files. Do these belong in NABS?

Current Behavior

Macros are scattered among the various hutch python installs

Context

pcdshub/Bug-Reports-and-Requests#31
@ZryletTC
Copy link
Contributor

ZryletTC commented Jan 8, 2021

Still kinda unclear what kind of macros this refers to. @ZLLentz could you give an example please?
I'm guessing this is different than the macros.py files that are in cxi, xcs, and mfx as those just look like extended beamline.py files. MFX's seems to be the only one with actual 'macros': laser_in() and laser_out() although those are mfx-specific (actually, CXI has some similar things too but it's a mess).

@ZLLentz
Copy link
Member Author

ZLLentz commented Jan 8, 2021

No, this is exactly the macros.py items if there are any in common. It's not like I bothered to read those files, so if there is truly no commonalities then we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ZryletTC @ZLLentz