Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more developer value via preferred header #105

Conversation

macyabbey
Copy link
Contributor

I've been delighted by wiretap.

As I've used it, I've often wished it could easily mock negative cases that are traditionally hard to test in services which are meant to not fail.

With a small change here to the mock server's algorithm for deciding selection of a mock response, we can unlock even more value from wiretap by mocking negative cases.

@daveshanley
Copy link
Member

I've been delighted by wiretap.

As I've used it, I've often wished it could easily mock negative cases that are traditionally hard to test in services which are meant to not fail.

With a small change here to the mock server's algorithm for deciding selection of a mock response, we can unlock even more value from wiretap by mocking negative cases.

I am so glad you're delighted!

My ultimate goal is this: "Creating software that is beautiful and easy to use. We believe that software should be enjoyable to use, and that it should inspire us."

It's very rewarding to see it manifest.

I love the addition, thank you. Once the test passes, I can merge it in!

@macyabbey
Copy link
Contributor Author

I love the addition, thank you. Once the test passes, I can merge it in!

Yay! Fixed the test and added another test case for a code branch that looked like it could panic to me.

@daveshanley daveshanley merged commit a7d6a8c into pb33f:main Apr 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants