Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Redirect Ignore List and Redirect Allow List #103

Conversation

jacobm-splunk
Copy link
Contributor

This MR adds support for:

  • An option (ignoreRedirect - list of path) to ignore redirects on certain paths.
  • A second option (redirectAllowList), which configures allowing redirect even if the path matches a path defined in ignoreRedirects

All options here support globbing

Copy link
Member

@daveshanley daveshanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, it follows the same patterns as the other allow/deny list features and gives us a lot more control over handling bouncy APIs.

cmd/root_command.go Show resolved Hide resolved
@daveshanley
Copy link
Member

I will update the docs on https://pb33f.io and then merge this in.

@daveshanley daveshanley merged commit 8b09671 into pb33f:main Mar 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants