New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar functions dont protect against invalid dates #492

Open

anton-seaice opened this issue Aug 21, 2024 · 0 comments

Collaborator

anton-seaice commented Aug 21, 2024

Some payu calendar functions allow invalid / impossible dates or runtimes. e.g:

payu/payu/calendar.py

Line 26 in 6de3bb5

def runtime_from_date(start_date, years, months, days, seconds, caltype):

Can produce a runtime less than 0.

Its not urgent, but there should be an error check for this and it could be a good excuse to audit the other calendar functions.

anton-seaice mentioned this issue

Replace CICE start date calculations #484

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment