Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Path #462

Open
anton-seaice opened this issue Jul 15, 2024 · 3 comments
Open

Sync Path #462

anton-seaice opened this issue Jul 15, 2024 · 3 comments

Comments

@anton-seaice
Copy link
Collaborator

Should the sync path configure follow the style as short path? Where the experiment name is added to the path provided.

i.e. if:

sync: 
    enable: True
    path: /g/data/$PROJECT/$USER

should this create a folder

/g/data/$PROJECT/$USER/<<experiment_name+uuid>>

automatically to sync to?

This seems especially useful when using the payu branch from a point in another experiment and you don't want to override the existing results ?

Current behavior is it will create the output folders directly in the path directory

@jo-basevi
Copy link
Collaborator

Yeah that's a good idea. My only concern is that it would break existing usage of sync (if there is any), by syncing all output in a new subfolder in the path directory. But it would be good way to ensure uniqueness in remote archive folder name.

I thought I had previously added in logic in the sync code to check if there was pre-existing metadata.yaml file with a matching UUID in the sync path to ensure it was the same experiment, but after looking at the code, I had not sorry..

@anton-seaice
Copy link
Collaborator Author

I think its only an issue if users change payu version part way through an experiment? Or try to add to an existing experiment which was run on an older payu?

The worst case is that an extra folder is created - it wouldn't be too hard to tidy up manually ... ?

@jo-basevi
Copy link
Collaborator

Yeah true, it would not be difficult to tidy up manually, and would only be an issue if changing payu versions during running an experiment.

Just a couple more thoughts about implementation:

  • Experiments that were started prior to UUID changes (payu versions < 1.1), still have an experiment name (the name used for archive directories) being the control directory name. For these experiments, should the default archive folder name that is being synced to, include an UUID to ensure uniqueness?
  • There could be an experiment option for the sync config, to allow overriding the default folder name if it's needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants