Do not throw button render errors when ref is invalid #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregjopa
force-pushed
the
update-render-error-strategy
branch
from
9064e74
to
685ef5e
Compare
Codecov Report
@@ Coverage Diff @@
## main #88 +/- ##
==========================================
- Coverage 92.72% 92.03% -0.70%
==========================================
Files 3 3
Lines 110 113 +3
Branches 33 34 +1
==========================================
+ Hits 102 104 +2
- Misses 8 9 +1
Continue to review full report at Codecov.
|
|
This empty container check was also needed: b85932b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to limit rendering errors related to the Buttons container being removed before async rendering completes. It's inspired by this PR for the zoid react driver that ships with the JS SDK: krakenjs/zoid#335.
Related: #85