Fixed Issue #119 #132
Open
Fixed Issue #119 #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tschelabaumann
suggested changes
Dec 29, 2016
| @@ -391,6 +391,8 @@ private function _createSubscription(array $response) | |||
| $model->setTrialStart($response['trial_start']); | |||
| $model->setTrialEnd($response['trial_end']); | |||
| $model->setNextCaptureAt($response['next_capture_at']); | |||
| $model->setEndOfPeriod($response['end_of_period']); | |||
| $model->setNextCaptureAt($response['next_capture_at']); | |||
There was a problem hiding this comment.
This line is double.
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I encountered the same issue as the one raised in #119. Did some digging and realised that the php library was actually missing elements which would allow the actual values to be returned, rather than just NULL.
Issue should be resolved now and will probably help quite a few people who have been struggling with this.
Regards
Christian
PS: This is my first public contribution of this sort on github, so please bear with me if this pull request isn't entirely according to best practice ;)