Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Id going into idnumber #15

Open
flartet opened this issue Jun 6, 2024 · 0 comments
Open

Id going into idnumber #15

flartet opened this issue Jun 6, 2024 · 0 comments

Comments

@flartet
Copy link

flartet commented Jun 6, 2024

Hello,
I have customized your plugin to work differently (I wish I had the time to publish it properly ...)
Still, I think there is a strange possible behaviour in locallib.php:97
$metagroup->idnumber = $group->id;
You're putting the group id of the existing group through the link to the idnumber but it is possible to have multiple link, so the same idnumber.
But, i can get the idnumber must not be unique (that's my case), why not putting idnumber into idnumber to have the same value and a better match between the group and its mirror ?
Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant