Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

deploy source distribution #25

Open
pattonw opened this issue Mar 12, 2019 · 3 comments
Open

deploy source distribution #25

pattonw opened this issue Mar 12, 2019 · 3 comments

Comments

@pattonw
Copy link
Owner

pattonw commented Mar 12, 2019

Upload source code for cases when built distributions are incompatible

At the moment install options are to pip install which installs compiled versions of the code which is great if you are on linux and use python 3.5 or 3.6. In other cases you can clone the github repo and build from source. Pip install should fall back on building from source if none of the compiled wheels are compatible.

twine has an sdist option to package up source code for this purpose, but it does not include any of the rust files when gathering code. Ideally we could find a way around this

@clbarnes
Copy link
Collaborator

I think this may be a MANIFEST issue - you need to explicitly include the rust source as well as the Cargo.toml.

@pattonw
Copy link
Owner Author

pattonw commented Mar 13, 2019

Good catch, that solved the issue for me.

@clbarnes
Copy link
Collaborator

Awesome! May be worth noting in the docs pip's --no-binary option in case people have a rust toolchain and would prefer to get the source from PyPI but compile locally (manylinux is designed for compatibility so it's not infeasible that local builds may have access to different instruction sets, although I don't know whether/when they'd be used).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants