Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card border is missing #7026

Closed
dlabrecq opened this issue Aug 29, 2024 · 2 comments
Closed

Card border is missing #7026

dlabrecq opened this issue Aug 29, 2024 · 2 comments
Assignees
Milestone

Comments

@dlabrecq
Copy link
Member

dlabrecq commented Aug 29, 2024

Please describe the issue

Wrapped a table with a Card per this PatternFly example. In both the PF example and Cost Management, the border is missing for the top-left corner. Also encountered the issue with the scrolling table. However, the entire left-side border is missing for that card.

Note that CardBody is omitted from the PF examples -- I've included it in my pages as a workaround.

Are there visuals for this issue? Please provide screenshots

Example 1
Screenshot 2024-08-29 at 5 00 09 PM

Example 2 (scroll table)
Screenshot 2024-08-29 at 8 35 16 PM

Could you point to a branch or draft PR where this issue exists? Please provide a link to the code

project-koku/koku-ui#3984

@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Aug 29, 2024
@dlabrecq dlabrecq changed the title Card border is missing rounded corner Card border is missing Aug 30, 2024
@mcoker
Copy link
Contributor

mcoker commented Sep 11, 2024

Hey @dlabrecq for v6, the design recommendation is to remove cards around tables and data-lists in layouts like that. Are you able to just remove the card? If not, can you try putting it in a regular card with padding?

@mcoker mcoker self-assigned this Sep 18, 2024
@mcoker
Copy link
Contributor

mcoker commented Sep 19, 2024

For this, let's try and move the default card border to the outside of the card (border is on .pf-v6-c-card, not on a pseudo element) and see if that works easily.

@mcoker mcoker moved this from Needs triage to Not started in PatternFly Issues Sep 19, 2024
@mcoker mcoker added this to the Penta final release milestone Sep 19, 2024
@kmcfaul kmcfaul modified the milestones: Penta final release, 2024.Q4 Oct 8, 2024
@github-project-automation github-project-automation bot moved this from Not started to Done in PatternFly Issues Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants