Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): tabs aria ssr compat #2863

Merged
merged 2 commits into from
Oct 9, 2024
Merged

fix(core): tabs aria ssr compat #2863

merged 2 commits into from
Oct 9, 2024

Conversation

bennypowers
Copy link
Member

What I did

  1. avoid browser globals/apis in tabs aria controller

Copy link

changeset-bot bot commented Oct 9, 2024

🦋 Changeset detected

Latest commit: e403f49

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@patternfly/pfe-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 9, 2024

✅ Commitlint tests passed!

More Info
{
  "valid": true,
  "errors": [],
  "warnings": [],
  "input": "fix(core): tabs aria ssr compat"
}

bennypowers added a commit to RedHat-UX/red-hat-design-system that referenced this pull request Oct 9, 2024
Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit c7ade27
😎 Deploy Preview https://deploy-preview-2863--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the AT passed Automated testing has passed label Oct 9, 2024
@bennypowers
Copy link
Member Author

Reviewed with Steven

@bennypowers bennypowers merged commit 7c855a6 into main Oct 9, 2024
14 of 16 checks passed
@bennypowers bennypowers deleted the fix/tabs/controller-ssr branch October 9, 2024 14:43
bennypowers added a commit to RedHat-UX/red-hat-design-system that referenced this pull request Oct 9, 2024
* docs: reduce number of file watchers

* docs: reimplement lit-ssr plugin

enable ssr for uxdot-pattern

* docs: implement ssr-able uxdot-pattern

* docs: migrate uxdot-pattern usage to ssr

* docs: fix pattern styles

* docs: headings slotted into pattern

* docs: watch for pattern files

* docs: resizable demo container

* chore: core patch

* chore: remove extra file

* docs: uxdot-pattern review comments

* docs(tabs): patterns

* docs: uxdot-pattern is not a provider

Rather, it's color-palette attribute forwards to the internal rh-surface

* docs: uxdot-pattern hydrate ssr state on client

* docs: uxdot pattern responsive padding

* docs: uxdot-pattern attrs

* docs: pattern usage

* feat: make generic ssr controller

* chore: update pfe-core patch

see patternfly/patternfly-elements#2863

* chore: update deps

* style: whitespace

* chore: update deps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AT passed Automated testing has passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant