Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark new PRs as red #21

Open
indirect opened this issue Aug 14, 2015 · 4 comments
Open

Mark new PRs as red #21

indirect opened this issue Aug 14, 2015 · 4 comments
Labels
d1:easy s3:detailed t1:enhancement

Comments

@indirect
Copy link
Contributor

Homu leaves a comment confirming that it saw the approval, maybe we could just add one status indicator that's green and says "approved by @person", and then a second status indicator for the travis build?
@indirect
Copy link
Contributor Author

Hell, better yet, we could automatically create a red status indicator that says "no one has reviewed and approved this code", blocking the merge button.

@segiddins
Copy link
Member

A pending indicator on the PR is added as soon as the PR is approved

@indirect
Copy link
Contributor Author

I noticed! 👍 I'm really fond of the idea of automatically marking any incoming PR red immediately as "not reviewed", though.

@segiddins
Copy link
Member

Sure!

@segiddins segiddins changed the title Immediate feedback so approvers know it worked Mark new PRs as red Aug 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
d1:easy s3:detailed t1:enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@indirect @chalkos @segiddins