Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to target merge to alternate branch #17

Open
segiddins opened this issue Aug 14, 2015 · 5 comments
Open

Add ability to target merge to alternate branch #17

segiddins opened this issue Aug 14, 2015 · 5 comments

Comments

@segiddins
Copy link
Member

patronus: test => branch
patronus: :+1: => branch

Thoughts?

@chalkos
Copy link
Collaborator

chalkos commented Jul 24, 2016

Using :+1:, if the test passes, should the PR be merged to a different branch? O_o

@chalkos chalkos closed this as completed Jul 24, 2016
@chalkos chalkos reopened this Jul 24, 2016
@segiddins
Copy link
Member Author

Yeah, that'd be the idea.

@chalkos
Copy link
Collaborator

chalkos commented Jul 24, 2016

That sounds strange to me (and I'm not even talking about the technical difficulties, like non-fastforwardable changes)... if the PR was opened to the wrong branch, one could just close it and open one to the correct branch, leaving a comment so someone else may follow the trail...

changing the target branch of a PR seems like something that github could implement (see isaacs/github#18), and not something for Patronus to do (unless you want to automate the closing-branch-and-opening-new-one part).

@segiddins
Copy link
Member Author

The problem is that you lose all the context & discussion on the PR, in addition to making more work for drive-by contributors

@chalkos
Copy link
Collaborator

chalkos commented Jul 25, 2016

I think it would be more confusing to drive-by contributors to see a PR from chalkos:bf-some-branch to patronus-io:master and then find out that the PR was closed without being merged and there is a message that seems to indicate that the PR was merged to patronus-io:dev instead (although github identifies the target as patronus-io:master).

A comment/description like "Wrong target branch, sorry. See #... for the correct pull request." would require an extra click from the reader, but would be less confusing IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants