-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to target merge to alternate branch #17
Comments
Using |
Yeah, that'd be the idea. |
That sounds strange to me (and I'm not even talking about the technical difficulties, like non-fastforwardable changes)... if the PR was opened to the wrong branch, one could just close it and open one to the correct branch, leaving a comment so someone else may follow the trail... changing the target branch of a PR seems like something that github could implement (see isaacs/github#18), and not something for Patronus to do (unless you want to automate the closing-branch-and-opening-new-one part). |
The problem is that you lose all the context & discussion on the PR, in addition to making more work for drive-by contributors |
I think it would be more confusing to drive-by contributors to see a PR from A comment/description like "Wrong target branch, sorry. See #... for the correct pull request." would require an extra click from the reader, but would be less confusing IMO. |
Thoughts?
The text was updated successfully, but these errors were encountered: