Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$scope.items is not tied to the vis.Dataset's #33

Open
grtjn opened this issue Nov 10, 2017 · 0 comments
Open

$scope.items is not tied to the vis.Dataset's #33

grtjn opened this issue Nov 10, 2017 · 0 comments

Comments

@grtjn
Copy link

grtjn commented Nov 10, 2017

This line in the docs is incorrect: https://github.com/patrickmcelwee/ml-visjs-graph-ng#get-access-to-the-visjs-nodes-and-edges

items holds the arrays of nodes and edges as provided from outside, not the vis DataSet objects to hold them. Exposing the items themselves is less useful, it is just as easy to override, and intercept graphSearch/graphExpand. Instead, access to the datasets would give more possibilities to tweak the graph according to needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant