Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate angular-bootstrap dependency #30

Open
grtjn opened this issue Nov 6, 2017 · 1 comment
Open

Eliminate angular-bootstrap dependency #30

grtjn opened this issue Nov 6, 2017 · 1 comment

Comments

@grtjn
Copy link

grtjn commented Nov 6, 2017

See https://github.com/patrickmcelwee/ml-visjs-graph-ng/blob/master/bower.json#L15

From what I can see, angular-bootstrap is not being used, only plain bootstrap css.

@grtjn
Copy link
Author

grtjn commented Nov 10, 2017

ml-visjs-graph-ng uses bootstrap grid layout (col-md-12 etc). That should be eliminated, or we should add bootstrap css to bower.json (instead of angular-bootstrap).

By the way, looks like dev on angular-(ui-)bootstrap has been ended, in favor of angular 2 ng-bootstrap. Another reason to not want to include it..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant