Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make title above graph configurable #26

Open
grtjn opened this issue Nov 6, 2017 · 5 comments
Open

Make title above graph configurable #26

grtjn opened this issue Nov 6, 2017 · 5 comments

Comments

@grtjn
Copy link

grtjn commented Nov 6, 2017

Text should be fully configurable, not just partially, and preferably title should be hide-able altogether.

Perhaps add a title option on the directive. If omitted you get old behavior. If provided it replaced original 'Link Analysis...' text with title. If provided but empty, hide title altogether.

@grtjn grtjn changed the title Consider dropping title above graph Make title above graph configurable Nov 6, 2017
@grtjn
Copy link
Author

grtjn commented Nov 6, 2017

I think it has already been removed in latest.. :)

@patrickmcelwee
Copy link
Owner

yes, I removed it ... I don't think it needs to be part of this library. And it was buggy. Agree?

@grtjn
Copy link
Author

grtjn commented Nov 6, 2017

Not sure i would call it buggy, or do you mean the value of ctrl.label? Most graphical components support some kind of title, but the one based on ctrl.label probably wasn't the best.. :)

@patrickmcelwee
Copy link
Owner

Our implementation was buggy. In cases where several nodes came in initially, there was randomness in WHICH label was used for the title. I agree that it could be supported, but I also think users can make their own title quick easily, so I personally don't think it's top priority.

@grtjn
Copy link
Author

grtjn commented Nov 6, 2017

yeah, a low prio nice to have for sure..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants