Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What about storing data for password-less access ? #10

Open
lrnv opened this issue Mar 30, 2024 · 2 comments
Open

What about storing data for password-less access ? #10

lrnv opened this issue Mar 30, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@lrnv
Copy link

lrnv commented Mar 30, 2024

Hey, great work on this.

I am currently using some HMD data for my work, and would really like to be able to store datasets directly into the packages (i.e. without asking end users for credentials). Taking a look at your code, I wander if you considered this option: did you saw somewhere a clause that does not allow you to redistribute the datas ?

I could for example think of a routine check in CI, ran say weekly or monthly, that would download and store the main zip file in some artefact dependency.

What do you think ?


Edit: From their user agreement, it looks like the datasets are CC BY 4.0, which means that we are free to redistribute them.

@patrickm663
Copy link
Owner

Hi Oskar

Thanks for the note.

Yeah that would definitely doable and rather pull from an archive up on GitHub. I'll look at what Alec did for his packages that distribute datasets. I initially did the password version to keep everything on their servers + access control.

I'll look at an automated runner to check once a month and then flag if they add new countries or tables that aren't considered yet.

@patrickm663 patrickm663 added the enhancement New feature or request label Mar 31, 2024
@patrickm663 patrickm663 self-assigned this Mar 31, 2024
@lrnv
Copy link
Author

lrnv commented Apr 1, 2024

Patrick,

For the moment, I drafted a script to download offline what i need in https://github.com/JuliaSurv/RateTables.jl (look in the data folder) but of course if I can depend directly on HMD.jl to obtain these datas that would be much cleaner :)

This would also require that HMD is registered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants