Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Trino transpilation of nullable single field ROW generated from EXCLUDE #46

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

alancai98
Copy link
Member

Issue #, if available:

Description of changes:

  • For background, PartiQL structs are represented by a ROW type. When there is just one field within the ROW type, then we must know the type when constructing the ROW.
-- in PartiQL, a struct with single field `a` of type `int4`
struct(a: int4)
-- in Trino, a row with a single field `a` of type `int4`
CAST(ROW(a) AS ROW(a INTEGER))

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@alancai98 alancai98 requested review from RCHowell and am357 June 4, 2024 20:21
@alancai98 alancai98 self-assigned this Jun 4, 2024
@RCHowell RCHowell merged commit 9a81a1a into main Jun 4, 2024
@RCHowell RCHowell deleted the fix-44 branch June 4, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trino transpilation failing for union(string, null)
2 participants