Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for INSERT INTO <qualified identifier> #1595

Open
3 tasks
johnedquinn opened this issue Sep 24, 2024 · 2 comments
Open
3 tasks

Support for INSERT INTO <qualified identifier> #1595

johnedquinn opened this issue Sep 24, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@johnedquinn
Copy link
Member

johnedquinn commented Sep 24, 2024

Requested Solution/Feature

  • Several of the DDL and DML statements don't allow for qualified identifiers. This ticket is specifically asking for support for insert statements with qualified identifiers.
  • The following should parse:
INSERT INTO some_catalog."some_SCHEMA".some_table VALUES (1, 2, 3);
  • Also, the experimental planner implementation should add planning support for this.

Additional Context

  • The AST and plan modeling on main currently do not have support for qualified identifiers. This should be addressed as part of this issue.
  • There is likely significant reworking of the definition of bindings. This is already handled on the v1 branch, however, this request is for main's experimental planner implementation.
  • This originally came as a request relevant to: Add dml update to partiql_logical pig domain and improve DML modeling #1592

DoD (Definition of Done)

  • AST and plan modeling adding support for qualified identifiers
  • Parser support for INSERT INTO <qualified identifier>
  • Planner support for qualified identifiers
@johnedquinn johnedquinn added the enhancement New feature or request label Sep 24, 2024
@hpolloni
Copy link

hpolloni commented Oct 3, 2024

Hey, although we would like to have planner and parser support for this feature. I think that at least fixing the grammar to support qualified identifiers would be a great first step.

@dlurton
Copy link
Member

dlurton commented Oct 14, 2024

In #1592, I didn't account for dotted targets in #1592 either, darnit. (record dml_target (identifier identifier)) should have been (record dml_target (* (identifier identifier) 1)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants