New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attach null stdio to pass nvm-windows check #76

Open

timgblack wants to merge 1 commit into parshap:master from timgblack:be-a-terminal-for-nvm-windows

timgblack commented Oct 18, 2024

https://github.com/coreybutler/nvm-windows/blob/6284f0ec44040764dc269144a3433664bf089646/src/nvm.go#L188
https://github.com/coreybutler/nvm-windows/blob/6284f0ec44040764dc269144a3433664bf089646/src/nvm.go#L73

In nvm-windows, if stdout isn't a character device, it shows an error dialog and waits for user input before terminating

Attach /dev/null to make sure that nvm-windows doesn't need intervention (https://nodejs.org/api/child_process.html#optionsstdio)


          Attach null stdio to pass nvm-windows check

e4ee748

https://github.com/coreybutler/nvm-windows/blob/6284f0ec44040764dc269144a3433664bf089646/src/nvm.go#L188
https://github.com/coreybutler/nvm-windows/blob/6284f0ec44040764dc269144a3433664bf089646/src/nvm.go#L73

In nvm-windows, if stdout isn't a character device, it shows an error dialog and waits for user input before terminating

Attach /dev/null to make sure that nvm-windows doesn't need intervention (https://nodejs.org/api/child_process.html#optionsstdio)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet