Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plain chain spec is not edited #1602

Closed
NachoPal opened this issue Dec 18, 2023 · 6 comments
Closed

Plain chain spec is not edited #1602

NachoPal opened this issue Dec 18, 2023 · 6 comments
Assignees

Comments

@NachoPal
Copy link

Issue Description

After paritytech/polkadot-sdk#1256, chain_spec.json format changed. Because of that, zombienet is not able to properly edit the plain_chain_spec.json. For example, it does not override the collators information since it is not able to find the key un the json file.

Steps to reproduce the issue

Try to deploy a Parachain using a polkadot-parachain client version after paritytech/polkadot-sdk#1256 was merged.

Describe the results you received

The parachain does not produce blocks because the Relay Chain is expecting different collator keys.

Describe the results you expected

chain_spec_plain.json to be properly edited with the correct collators. Parachain producing blocks

Zombienet version

@zombienet/cl: 1.3.77

Provider

Native

Provider version

polkadot-parachain v1.4.0

Upstream Latest Release

No

Additional environment details

Additional environment details

Additional information

Additional information like issue happens only occasionally or issue happens with a particular architecture or on a particular setting

Screenshots

No response

@bkchr
Copy link
Member

bkchr commented Dec 18, 2023

How is CI working then? And there was also some fix here: #1469

@NachoPal
Copy link
Author

How is CI working then? And there was also some fix here: #1469

Might be the version then, sorry. I talked to @pepoviola before and I understood it had not been addressed yet.

@pepoviola
Copy link
Collaborator

How is CI working then? And there was also some fix here: #1469

Might be the version then, sorry. I talked to @pepoviola before and I understood it had not been addressed yet.

Hey @NachoPal can you try with the latest version v1.3.86. This should work as expected.
Thx!

@NachoPal
Copy link
Author

I just tried with v1.3.86 and same result. It is not overriding the collators info

@pepoviola
Copy link
Collaborator

info

Can you send me your config (toml) file to reproduce locally?
Thx!

@pepoviola pepoviola self-assigned this Dec 18, 2023
@NachoPal
Copy link
Author

I wasn't really using v1.3.86. It works as expected, sorry for the noise! Closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants