Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs feature #109

Closed
ascjones opened this issue Jul 7, 2021 · 0 comments · Fixed by #116
Closed

Improve docs feature #109

ascjones opened this issue Jul 7, 2021 · 0 comments · Fixed by #116

Comments

@ascjones
Copy link
Contributor

ascjones commented Jul 7, 2021

Currently the docs feature only excludes docs for derived TypeInfo. We should also exclude docs added from manual impls via the docs builder methods.

As suggested by @thiolliere paritytech/substrate#8615 (comment) the docs methods could be inlined and made a no-op if the docs feature is disabled. We would need to double check that this works as intended by not including the static strings in the resulting Wasm.

A similar technique could also be used together with this in frame-metadata, to remove all docs. See paritytech/frame-metadata#6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant