Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

str: Ensure the input data is correct #54

Merged
merged 2 commits into from
May 7, 2024
Merged

str: Ensure the input data is correct #54

merged 2 commits into from
May 7, 2024

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented May 7, 2024

Also change Compact<u64> to Compact<u32> to reflect the actual upper limit.

Also change `Compact<u64>` to `Compact<u32>` to reflect the actual upper
limit.
@bkchr bkchr requested a review from a team as a code owner May 7, 2024 10:08
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again :)

We have a bunch of tests for decoding valid encoded values, but this is a good reminder to add tests to check that panics etc are avoided with improperly encoded data; I'll create an issue for this!

@jsdw jsdw merged commit c9fcc18 into main May 7, 2024
10 checks passed
@jsdw jsdw deleted the bkchr-str branch May 7, 2024 10:35
@jsdw jsdw mentioned this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants