Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bit-sequence: Checked decode #53

Merged
merged 3 commits into from
May 7, 2024
Merged

bit-sequence: Checked decode #53

merged 3 commits into from
May 7, 2024

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented May 7, 2024

Decode the bytes using checked access. This ensures we don't panic on missing input.

Decode the bytes using checked access. This ensures we don't panic on
missing input.
@bkchr bkchr requested a review from a team as a code owner May 7, 2024 08:17
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@jsdw jsdw merged commit 9981a2c into main May 7, 2024
10 checks passed
@jsdw jsdw deleted the bkchr-bit-sequence-fix branch May 7, 2024 09:21
@bkchr
Copy link
Member Author

bkchr commented May 7, 2024

@jsdw can you do a release please?

@bkchr
Copy link
Member Author

bkchr commented May 7, 2024

Okay wait, I found more :D

@jsdw
Copy link
Collaborator

jsdw commented May 7, 2024

Hehe sure thing; lemme know when you're happy and we can put a release out for sure! I'll add some quick proptests too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants