Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove need for TypeId to impl Default #46

Open
jsdw opened this issue Feb 9, 2024 · 0 comments
Open

Remove need for TypeId to impl Default #46

jsdw opened this issue Feb 9, 2024 · 0 comments

Comments

@jsdw
Copy link
Collaborator

jsdw commented Feb 9, 2024

In a couple of places eg #45 (comment), we lean on the visit_composite implementation to handle some decoding. This requires a TypeId (which we don't care about), and so we just provide some default thing because we have no actual ID. This leads us to needing TypeId: Default, which is a bit of a hack.

Let's tweak the code so that we don't need this, and then we can remove the bound on scale-type-resolver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant