Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Refactor subsystem TestHarness to remove duplicated code across subsystems #3271

Open
Lldenaurois opened this issue Jun 16, 2021 · 0 comments
Assignees
Labels
I5-tests Tests need fixing, improving or augmenting. I8-refactor Code needs refactoring.

Comments

@Lldenaurois
Copy link
Contributor

Currently, the AV-Store, ApprovalDistribution, AvailabilityRecovery and CollatorProtocol subsystems all implement similar logic around full subsystem tests, i.e. overseer_send, overseer_recv, overseer_recv_with_timeout, overseer_signal.

It may be beneficial to move these functions to the test-helpers crate and subsequently refactor the tests for these subsystems to all leverage the same (somewhat generic) functions around virtual_overseer message passing.

Assigning to myself for now.

@Lldenaurois Lldenaurois self-assigned this Jun 16, 2021
@rphmeier rphmeier added I8-refactor Code needs refactoring. I5-tests Tests need fixing, improving or augmenting. labels Jun 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I5-tests Tests need fixing, improving or augmenting. I8-refactor Code needs refactoring.
Projects
None yet
Development

No branches or pull requests

2 participants