-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
approval-voting
: experiment with batching signature checks
#730
Comments
I vaguely recalled "batching" here does not mean "cryptographic batching" like I mentioned in #730? |
Yep, it is actually not, but stacks with "cryptographic batching" as we scale up validator and parachain count. It's mostly about improving our architecture of processing approval voting gossip messages and slicing the CPU intensive work. |
4 tasks
the-right-joyce
added
T8-parachains_engineering
and removed
T4-parachains_engineering
labels
Aug 25, 2023
4 tasks
claravanstaden
added a commit
to Snowfork/polkadot-sdk
that referenced
this issue
Dec 8, 2023
* Force type 2 eth transactions * Adds lock file changes. * Use import instead of require.
helin6
pushed a commit
to boolnetwork/polkadot-sdk
that referenced
this issue
Feb 5, 2024
* Add BLOCK_TIMESTAMP config for ts-tests Signed-off-by: koushiro <[email protected]> * Add NODE_BINARY_NAME Signed-off-by: koushiro <[email protected]> * Improve test-balances Signed-off-by: koushiro <[email protected]> * Some nits Signed-off-by: koushiro <[email protected]> * Add RUNTIME_SPEC_NAME, RUNTIME_SPEC_VERSION, RUNTIME_IMPL_VERSION Signed-off-by: koushiro <[email protected]> * Some nits Signed-off-by: koushiro <[email protected]> * Use CHAIN_ID Signed-off-by: koushiro <[email protected]> * Some nits Signed-off-by: koushiro <[email protected]> * Improve test-revert-receipt Signed-off-by: koushiro <[email protected]> * Use camelCase Signed-off-by: koushiro <[email protected]> * Use tabs Signed-off-by: koushiro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We could additionally gain some performance by batching signature checks. Right now we check them individually by handling
CheckAndImportAssignment
andCheckAndImportApproval
. We have to test if there are any significant gains by doing something like, buffering signature checks until reach a limit or N milliseconds have passed since we started buffering. This would play nicely with #731.Another approach is to do the batching in
approval-distribution
but I am not really sure if this would be more effective.The text was updated successfully, but these errors were encountered: