Tests to ensure create bounty actually works

[xlc]

There was bad config breaks the ability for root and council to create bounty. No one caught that. That means we need more tests.

[bkchr]

Cc @s3krit

[s3krit]

Is there a fix for this already merged? If so, when was the first and last known-bad commits?

[xlc]

https://github.com/paritytech/polkadot/blob/645723987cf9662244be8faf4e9b63e8b9a1b3a3/runtime/polkadot/src/lib.rs#L859 is the bad config in v0.9.37. Use blame to find the previous commit without this.
I don't know if it is fixed on master but the OpenGov code changed the config again. You will find it out with some tests.

[s3krit]

I'm pretty sure I'm misunderstanding this issue. As per the bounties pallet in substrate, 'The dispatch origin for this call must be Signed.':

https://github.com/paritytech/substrate/blob/master/frame/bounties/src/lib.rs#L324

and sure enough, modifying the test to use RuntimeOrigin::root() causes the propose_bounty_works test to fail with BadOrigin. Which sounds to me like it was never intended to be able to propose a bounty as root. That being said, I also spun up kusama and polkadot dev chains and used chopsticks to insert Alice into the council and attempted to propose & execute a bounty, which also fails with BadOrigin, despite Kusama and Polkadot now using type SpendOrigin = TreasurySpender; (which is EitherOf<EnsureRootWithSuccess<AccountId, MaxBalance>, Spender>;), which confirms the behaviour you described.

Please let me know if I've missed something or just completely misunderstood :) Either way, I've written a little e2e regression test using zombienet to test the bounties implementation in polkadot, which I'll add to my set of regression tests. I'm guessing we'd also want a unit test adding to either the bounties pallet itself, or polkadot/kusama's tests

[bkchr]

despite Kusama and Polkadot now using type SpendOrigin = TreasurySpender; (which is EitherOf<EnsureRootWithSuccess<AccountId, MaxBalance>, Spender>;), which confirms the behaviour you described.

Council is not a root origin, so you will need to change this to the correct origin.

[shawntabrizi]

@the-right-joyce should be marked as easy and good first issue please

[bkchr]

The issue does not belong here anymore. I created a new one: polkadot-fellows/runtimes#232