Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[network] Confirm and get rid of keep-alives in Notifications protocol #6350

Open
dmitry-markin opened this issue Nov 4, 2024 · 3 comments
Open

[network] Confirm and get rid of keep-alives in Notifications protocol #6350

dmitry-markin opened this issue Nov 4, 2024 · 3 comments
Labels
I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue. T0-node This PR/Issue is related to the topic “node”.

Comments

@dmitry-markin
Copy link
Contributor

After #6248 is merged, manually keeping streams alive during additional keep-alive timeout should not be needed.

Confirm this and get rid of it.
@dmitry-markin dmitry-markin added T0-node This PR/Issue is related to the topic “node”. I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue. labels Nov 4, 2024
@nazar-pc
Copy link
Contributor

nazar-pc commented Nov 4, 2024

I believe this is what #6109 does, I specifically did kademlia_legacy_protocol: _, in #6248 to reduce inevitable merge conflict with it.

@dmitry-markin
Copy link
Contributor Author

I believe this is what #6109 does, I specifically did kademlia_legacy_protocol: _, in #6248 to reduce inevitable merge conflict with it.

This seems not related to Notifications protocol keep-alive timeouts for me.

@nazar-pc
Copy link
Contributor

nazar-pc commented Nov 5, 2024

Indeed, I didn't read it carefully 🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue. T0-node This PR/Issue is related to the topic “node”.
Projects
Networking
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nazar-pc @dmitry-markin