Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop warnings and deprecations failing tests #877

Closed
DiogoTheCoder opened this issue Aug 28, 2024 · 1 comment · Fixed by #897
Closed

Stop warnings and deprecations failing tests #877

DiogoTheCoder opened this issue Aug 28, 2024 · 1 comment · Fixed by #897

Comments

@DiogoTheCoder
Copy link

I'm currently trying to upgrade from PHPUnit v9 to v10 and I've got many deprecations which don't fail the PHPUnit tests but are failing when I try to run them under Paratest in a CI pipeline - currently when I run the below it will return with the exit code 1, is there anyway to ignore warnings and deprecations, ignoring them or changing the exit code?

    docker run -t \
        -v $(pwd)/build:/data/www/pam/somic/build \
        -v $(pwd):/data/www/pam/somic/ \
        -v /data/www/pam/somic/vendor/ \
        -e XDEBUG_MODE=coverage \
        --user $(id -u):$(id -g) \
        --network somic-parallel-test-network \
        "${docker_image}" \
        "/data/www/pam/somic/vendor/bin/paratest \
            -p$processes \
            --runner=WrapperRunner \
            --log-junit /data/www/pam/somic/build/junit-phpunit-php-82-pg-14.xml \
            /data/www/pam/somic/tests"
@peterfox
Copy link

peterfox commented Oct 2, 2024

I am also suffering from this currently. Running it in PHPUnit directly doesn't show the PHPUnit deprecations but Paratest will

Edit: solved my problem. It works with #894. The only problem is that the version the patch exists in only works with PHPUnit 11 so the only way to resolve it is with a local patch for PHPUnit 10 users.

@Slamdunk Slamdunk linked a pull request Oct 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants