Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize Check Names #1242

Open
2 tasks
katherinejensen00 opened this issue Oct 25, 2024 · 3 comments
Open
2 tasks

Localize Check Names #1242

katherinejensen00 opened this issue Oct 25, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@katherinejensen00
Copy link
Contributor

User Story
As a user, I want to see check names in my interface language so that I know which checks I am running.

Description
Localize check names.

Implementation idea

  • Determine and implement a way to localize check names coming from Paratext 9 check files.
  • Localize relevant extension check names (if any)
@katherinejensen00 katherinejensen00 added enhancement New feature or request ux UX design needed and removed ux UX design needed labels Oct 25, 2024
@tombogle
Copy link
Contributor

These are already localizable in P9. The strategy there might not extend to our world where the checks are less of a closed set, but so perhaps we can look at how it's done in P9 to see. Our strategy will also need to account for checks that are developed in an extension, but there I'm guessing the existing Platform localization strategy should cover the need.

@tjcouch-sil
Copy link
Member

Regarding taking advantage of Paratext 9's localized strings, there's a bullet called "Paratext 9 Fallback Keys" in the style guide that explains how we should structure our localized string metadata in order to prepare for pulling forward the P9 localization data from Crowdin one day (we have not done this yet but plan to do so).

Essentially, if there's already a string in P9 that matches the text and purpose of the string you're making in Platform.Bible, you should add the P9 string key as a fallback. There's an example linked in the style guide :)

@Sebastian-ubs
Copy link
Contributor

Also have in mind that for settings we talked about the ability to search settings using the old setting name, even when we use a new one in PT10. We might want to do something similar for other areas of the product as well, so e.g. if there is a filter to filter checks and we decide to rename a check, still you should be able to filter by the old name and get a reasonable hint (to be defined how that looks like) about why this matches.
For this I have created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants