Fix invalid string length when saving large PDF #3646
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ily |
|
I left a temporary solution for anyone that needs a working fix now before a fix is merged. |
|
@HackbrettXXX Sorry to bother you, but you are the only one active in this repository. This is a valid fix to saving large PDF. Can you help merge this, instead of letting it be closed by the stale bot? |
|
bump 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1724. This fixes the invalid string length error when saving a large PDF.
Based on #3625 by @shiina-mash1ro, I have rewritten the output of
buildDocument()following the existing convention, and expanded on the case for blob in addition to array buffer.#3625 bypassed the string limit with an array buffer, but there is still a limit to how big an array buffer can be. This further increases the limit for blob by not putting everything in the same array buffer, allowing the creation of a much bigger PDF when saving as blob.
I have updated the test cases and reference PDFs for this change.